fix: convert oneOf to anyOf in strict schema for discriminated unions#5324
Merged
fix: convert oneOf to anyOf in strict schema for discriminated unions#5324
Conversation
Pydantic emits oneOf for discriminated unions, but OpenAI strict mode rejects oneOf. Convert oneOf to anyOf which is semantically equivalent and accepted by the API. Fixes #5302
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
chenghao-mou
approved these changes
Apr 3, 2026
Contributor
|
thanks!! |
osimhi213
added a commit
to de-id/livekit-agents
that referenced
this pull request
Apr 5, 2026
* upstream/main: fix: add PARTICIPANT_KIND_CONNECTOR to default participant kinds (livekit#5339) feat: expose service_tier in CompletionUsage from OpenAI Responses API (livekit#5341) feat: answering machine detection (livekit#4906) fix: wait_for_participant waits until participant is fully active (livekit#5271) (gemini realtime): add warnings in update_chat_ctx and update_instructions (livekit#5332) fix: convert oneOf to anyOf in strict schema for discriminated unions (livekit#5324) fix(voice): make function call history preservation configurable in AgentTask (livekit#5288)
osimhi213
added a commit
to de-id/livekit-agents
that referenced
this pull request
Apr 5, 2026
* fix(voice): make function call history preservation configurable in AgentTask (livekit#5288) * fix: convert oneOf to anyOf in strict schema for discriminated unions (livekit#5324) * (gemini realtime): add warnings in update_chat_ctx and update_instructions (livekit#5332) * fix: wait_for_participant waits until participant is fully active (livekit#5271) * feat: answering machine detection (livekit#4906) Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com> * feat: expose service_tier in CompletionUsage from OpenAI Responses API (livekit#5341) * fix: add PARTICIPANT_KIND_CONNECTOR to default participant kinds (livekit#5339) --------- Co-authored-by: Gopal Bagaswar <67310594+GopalGB@users.noreply.github.com> Co-authored-by: Long Chen <longch1024@gmail.com> Co-authored-by: Tina Nguyen <72938484+tinalenguyen@users.noreply.github.com> Co-authored-by: David Zhao <dz@livekit.io> Co-authored-by: Chenghao Mou <chenghao.mou@livekit.io> Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Piyush Gambhir <90608533+piyush-gambhir@users.noreply.github.com> Co-authored-by: Anunay Maheshwari <anunaym14@gmail.com>
russellmartin-livekit
pushed a commit
that referenced
this pull request
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
oneOffor discriminated unions (e.g.,Annotated[Car | Bike, Field(discriminator="vehicle")]), but OpenAI strict mode rejectsoneOfwith'oneOf' is not permittedoneOftoanyOfin_ensure_strict_json_schema, which is semantically equivalent and accepted by the APIFixes #5302