Skip to content

(gemini live 3.1): fix tool responses#5413

Merged
tinalenguyen merged 6 commits intomainfrom
tina/refactor-gemini-rt
Apr 11, 2026
Merged

(gemini live 3.1): fix tool responses#5413
tinalenguyen merged 6 commits intomainfrom
tina/refactor-gemini-rt

Conversation

@tinalenguyen
Copy link
Copy Markdown
Member

@tinalenguyen tinalenguyen commented Apr 11, 2026 •
edited
Loading

send tool results without touching send_client_content for gemini 3.1 via capabiltiies.mutable_* guards. also remove shutdown model (source)

verified via survey agent and these models:
"gemini-live-2.5-flash-native-audio"
"gemini-3.1-flash-live-preview"
"gemini-2.5-flash-native-audio-preview-12-2025"

thank you to @leonobitech and @FMFigueroa for providing the context to this issue 😄

@chenghao-mou chenghao-mou requested a review from a team April 11, 2026 01:25
devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

@tinalenguyen tinalenguyen mentioned this pull request Apr 11, 2026
Closed
devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

@FMFigueroa
Copy link
Copy Markdown

FMFigueroa commented Apr 11, 2026

Hey @tinalenguyen, reviewed #5413 — much better approach. Keeping the fix scoped to the plugin instead of touching core makes sense, especially with multiple providers depending on a stable base. The mutable_chat_context gate is clean. Happy to close my PR in favor of this one.

davidzhao
davidzhao approved these changes Apr 11, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread livekit-plugins/livekit-plugins-google/livekit/plugins/google/realtime/realtime_api.py
)
if turns:
self._send_client_event(types.LiveClientContent(turns=turns, turn_complete=False))
if self._realtime_model.capabilities.mutable_chat_context:
Copy link
Copy Markdown
Member

@davidzhao davidzhao Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we log a warning if it's not mutable?

Copy link
Copy Markdown
Member Author

@tinalenguyen tinalenguyen Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i added a warning here in the init, could be kinda noisy in update_chat_ctx

Copy link
Copy Markdown
Member

@davidzhao davidzhao Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, that makes sense

@tinalenguyen tinalenguyen merged commit 3e51d8e into main Apr 11, 2026
25 of 27 checks passed
@tinalenguyen tinalenguyen deleted the tina/refactor-gemini-rt branch April 11, 2026 05:15
@tinalenguyen tinalenguyen mentioned this pull request Apr 11, 2026
Merged
@rahulmanuwas rahulmanuwas mentioned this pull request Apr 11, 2026
Open
russellmartin-livekit pushed a commit that referenced this pull request Apr 13, 2026
@tinalenguyen @russellmartin-livekit
(gemini live 3.1): fix tool responses (#5413)
25700be
leonobitech pushed a commit to leonobitech/backend that referenced this pull request Apr 14, 2026
@FMFigueroa
chore(voice-agent): switch to main branch of livekit agents fork
0eb9ccc 
🔄 Update livekit-agents dependency from @fix/gemini-3.1-tool-response to @main
🔄 Update livekit-plugins-google dependency from @fix/gemini-3.1-tool-response to @main
✅ Fix merged upstream via livekit/agents#5413

🚀 Powered by Claude Opus 4.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidzhao davidzhao davidzhao approved these changes

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tinalenguyen @FMFigueroa @davidzhao