Normalize trunk filtering #1126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st Filter 1. Added normalization to the comparison of trunk and caller number in ListSIPInboundTrunkRequest 2. Moved NormalizeNumber to a utils number to prevent import cycle
🦋 Changeset detectedLatest commit: 58f54de The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
dennwc
approved these changes
Jul 4, 2025
utils/sip/sip_processing.go
Outdated
| // NormalizeNumber normalizes a phone number by removing formatting characters and ensuring it starts with a "+". | ||
| // If the input is empty, it returns an empty string. | ||
| // If the input doesn't match the expected number pattern, it returns the original input unchanged. | ||
| func NormalizeNumber(num string) string { |
Contributor
There was a problem hiding this comment.
It could be in livekit/sip.go as well, instead of a new utils package.
livekit/sip.go
Outdated
| for _, num := range info.Numbers { | ||
| if slices.Contains(p.Numbers, num) { | ||
| ok = true | ||
| normalizedNum := siputils.NormalizeNumber(num) |
Contributor
There was a problem hiding this comment.
Could you also keep a direct slices.Contains(p.Numbers, num) check as well? We don't need to call regexp if the numbers match exactly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.