Allow clients to specify video layers mode. #1158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main issue is distinguishing between one RTP streaming carry multiple spatial layers (example SVC codecs) vs one spatial layer (codecs that are typically simulcast). The enum names are long, but wanted them to be clear.
🦋 Changeset detectedLatest commit: b716414 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
boks1971
commented
Aug 9, 2025
| string cid = 1; | ||
| string name = 2; | ||
| TrackType type = 3; | ||
| // to be deprecated in favor of layers |
Contributor
Author
There was a problem hiding this comment.
removing this comment as this is used in adaptive streaming and also useful to have this as capture size or max size. The width and height are also in UpdateLocalVideoTrack message. So, this comment is misleading.
davidzhao
approved these changes
Aug 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main issue is distinguishing between one RTP streaming carry multiple spatial layers (example SVC codecs) vs one spatial layer (codecs that are typically simulcast). The enum names are long, but wanted them to be clear.