Skip to content

Unique IDs for analytics events and stats #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidzhao merged 3 commits into from
Jun 14, 2024
Merged

Unique IDs for analytics events and stats #739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b7a84e
Unique IDs for analytics events and stats
davidzhao Jun 14, 2024
558f2ee
generated protobuf
github-actions[bot] Jun 14, 2024
4446b75
changeset
davidzhao Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/stale-windows-remember.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"github.com/livekit/protocol": patch
---

Include analytics event ids
28 changes: 24 additions & 4 deletions livekit/livekit_analytics.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 7 additions & 1 deletion protobufs/livekit_analytics.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ message AnalyticsStream {
}

message AnalyticsStat {
// unique id for this stat
string id = 14;
string analytics_key = 1;
StreamType kind = 2;
google.protobuf.Timestamp time_stamp = 3;
Expand All @@ -70,6 +72,8 @@ message AnalyticsStat {
string mime = 11;
float min_score = 12;
float median_score = 13;

// NEXT_ID: 15
}

message AnalyticsStats {
Expand Down Expand Up @@ -123,6 +127,8 @@ message AnalyticsClientMeta {
}

message AnalyticsEvent {
// unique id for this event
string id = 25;
AnalyticsEventType type = 1;
google.protobuf.Timestamp timestamp = 2;
string room_id = 3;
Expand All @@ -146,7 +152,7 @@ message AnalyticsEvent {
int32 video_layer = 22;
string node_id = 24;

// NEXT_ID: 25
// NEXT_ID: 26
}

message AnalyticsEvents {
Expand Down