avoid reconnection logs on normal close #449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidzhao
approved these changes
Sep 30, 2024
Member
davidzhao
left a comment
davidzhao
left a comment
There was a problem hiding this comment.
nit on the log, otherwise lgtm
| proto::leave_request::Action::Resume | ||
| | proto::leave_request::Action::Reconnect => { | ||
| log::warn!( | ||
| "received session close: {:?} {:?} {:?}", |
Member
There was a problem hiding this comment.
Suggested change
| "received session close: {:?} {:?} {:?}", | |
| "received server-initiated reconnect: {:?} {:?} {:?}", |
Member
Author
There was a problem hiding this comment.
it isn't necessarily server-initiated, this part needs cleanup but it is also called when the SignalClient is being closed unexpectedly. In this case we create our own leave_request locally with the reason Unknown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.