put examples in root Cargo workspace #731

Be-ing · 2025-10-09T07:09:29Z

instead of their own workspace. This avoids rebuilding dependencies and wasting space with multiple target directories.

ladvoc · 2025-10-10T02:22:22Z

@Be-ing, it looks like this change is causing the test jobs to fail.

Be-ing · 2025-10-10T03:23:55Z

yep will look into that

Be-ing · 2025-10-14T04:57:54Z

That took a bit more work than I anticipated, but tests are passing now.

ladvoc

Overall, this looks great—just a few minor comments.

.github/workflows/tests.yml

examples/basic_room/src/main.rs

examples/send_bytes/Cargo.toml

Cargo.toml

ladvoc · 2025-10-14T12:53:36Z

Everything looks good now, except build is failing on Android. From a quick look at the logs, it looks like it isn't related to this PR—I will address that so we can get this merged.

Be-ing · 2025-10-14T16:29:58Z

That might be related to this PR if this PR accidentally changed the Cargo feature for TLS that gets selected on Android.

instead of their own workspace. This avoids rebuilding dependencies and wasting space with multiple target directories.

This is required now that the examples are in the root workspace. Otherwise, each seperate example would enable conflicting features on livekit-runtime. Avoid this by using Cargo features in one crate to select between runtimes.

like all the other examples

There's no need to specify these in the workspace's Cargo.toml. Cargo reads the versions from each crate's Cargo.toml.

Different examples used different backends, which doesn't work great in a workspace.

libc++abi does not need to be manually linked. Doing so breaks linking when failing to find pthread.

It fails to link for aarch64 Android: = note: ld.lld: error: undefined symbol: __arm_tpidr2_save >>> referenced by rotate_sme.cc >>> rotate_sme.o:(TransposeWxH_SME) in archive /home/runner/work/rust-sdks/rust-sdks/target/aarch64-linux-android/release/deps/libwebrtc_sys-8a55d18259959b0a.rlib

Be-ing · 2025-10-14T23:26:54Z

I got Android builds to work again. The wgpu_room example fails to link on aarch64 Android with a strange error:

  = note: ld.lld: error: undefined symbol: __arm_tpidr2_save
          >>> referenced by rotate_sme.cc
          >>>               rotate_sme.o:(TransposeWxH_SME) in archive /home/runner/work/rust-sdks/rust-sdks/target/aarch64-linux-android/release/deps/libwebrtc_sys-8a55d18259959b0a.rlib

I don't know what to make of that error; it might take a deep dive into how libwebrtc.a is built for Android (which I don't plan to do) to resolve. I think just skipping building that one crate is fine for now.

Phew, that was a hairy yak to shave 🪒

ladvoc · 2025-10-14T23:45:03Z

Agreed, skipping that example for Android is fine.

ladvoc

LGTM ✅

ladvoc · 2025-10-16T10:51:32Z

Hey @Be-ing, if you're up for another contribution, we have a new CI build issue for Android—it appears to be different than the one you fixed on this PR:

cargo:warning=Could not find directory of OpenSSL installation, and this `-sys` crate cannot proceed without this knowledge. If OpenSSL is installed and this crate had trouble finding it, you can set the `OPENSSL_DIR` environment variable for the compilation process. See stderr section below for further information.

Example run: https://github.com/livekit/rust-sdks/actions/runs/18541840496

Be-ing · 2025-10-16T13:57:30Z

I don't know what might have caused that considering that CI for the commit before it passed and the commit that failed to build doesn't seem to touch anything build related...

Removed by #731, but required to publish to crates.io.

Be-ing force-pushed the examples_workspace branch 2 times, most recently from 7089937 to e82f26d Compare October 14, 2025 04:28

ladvoc self-requested a review October 14, 2025 06:49

ladvoc reviewed Oct 14, 2025

View reviewed changes

.github/workflows/tests.yml Show resolved Hide resolved

examples/basic_room/src/main.rs Show resolved Hide resolved

examples/send_bytes/Cargo.toml Show resolved Hide resolved

Cargo.toml Show resolved Hide resolved

Be-ing force-pushed the examples_workspace branch 6 times, most recently from 1ca712a to e7aa07d Compare October 14, 2025 07:56

ladvoc self-assigned this Oct 14, 2025

Be-ing force-pushed the examples_workspace branch 5 times, most recently from cfde24f to 4b80220 Compare October 14, 2025 18:50

Be-ing added 9 commits October 14, 2025 16:57

put examples in root Cargo workspace

08a90a6

instead of their own workspace. This avoids rebuilding dependencies and wasting space with multiple target directories.

consolidate basic_room examples

87f8197

This is required now that the examples are in the root workspace. Otherwise, each seperate example would enable conflicting features on livekit-runtime. Avoid this by using Cargo features in one crate to select between runtimes.

cargo fmt examples

b2271aa

use Rust 2021 edition for send_bytes example

25012af

like all the other examples

remove redundant specification of crate versions

f6ce946

There's no need to specify these in the workspace's Cargo.toml. Cargo reads the versions from each crate's Cargo.toml.

use workspace = true in examples instead of path = ...

5fa3af4

GH Actions: add libasound2-dev package for cpal

cbe63c8

only demonstrate tokio in basic_room example

ef9ba49

don't select TLS backend in examples

ce0de12

Different examples used different backends, which doesn't work great in a workspace.

Be-ing added 2 commits October 14, 2025 16:57

select android-native-activity backend for winit

e645112

use default features for workspace crates

29de9da

Be-ing force-pushed the examples_workspace branch from e3b4ba1 to b2f4956 Compare October 14, 2025 21:59

Be-ing added 3 commits October 14, 2025 17:03

fix Android builds

43b7a31

libc++abi does not need to be manually linked. Doing so breaks linking when failing to find pthread.

make rpc example crate name match directory name

d11a312

cargo update

3c08efc

Be-ing force-pushed the examples_workspace branch 3 times, most recently from e71f284 to 123cb2a Compare October 14, 2025 22:58

Be-ing force-pushed the examples_workspace branch from 123cb2a to da4a060 Compare October 14, 2025 23:07

ladvoc self-requested a review October 14, 2025 23:44

ladvoc approved these changes Oct 14, 2025

View reviewed changes

ladvoc merged commit f471d99 into livekit:main Oct 14, 2025
16 checks passed

github-actions bot mentioned this pull request Oct 14, 2025

chore: release #743

Merged

Be-ing deleted the examples_workspace branch October 15, 2025 02:07

This was referenced Oct 15, 2025

Cargo workspace cleanup #745

Merged

Expose desktop capturer #725

Merged

ladvoc added a commit that referenced this pull request Oct 22, 2025

Specify workspace dependency versions

8a1c208

Removed by #731, but required to publish to crates.io.

ladvoc mentioned this pull request Oct 22, 2025

Prepare for release #760

Merged

Be-ing mentioned this pull request Oct 24, 2025

fix: fix unable to locate __arm_tpidr2_save for android ffi. #765

Merged

Be-ing mentioned this pull request Nov 13, 2025

Use libwebrtc's DesktopCapturer for screen capture zed-industries/zed#42670

Closed

22 tasks

put examples in root Cargo workspace #731

put examples in root Cargo workspace #731

Uh oh!

Conversation

Be-ing commented Oct 9, 2025

Uh oh!

ladvoc commented Oct 10, 2025

Uh oh!

Be-ing commented Oct 10, 2025

Uh oh!

Be-ing commented Oct 14, 2025

Uh oh!

ladvoc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ladvoc commented Oct 14, 2025

Uh oh!

Be-ing commented Oct 14, 2025

Uh oh!

Be-ing commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ladvoc commented Oct 14, 2025

Uh oh!

ladvoc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ladvoc commented Oct 16, 2025

Uh oh!

Be-ing commented Oct 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Be-ing commented Oct 14, 2025 •

edited

Loading