Conversation
🦋 Changeset detectedLatest commit: e1399c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…s async / could slow down loading more
…time it is enabled
1egoman
force-pushed
the
cache-background-image
branch
from
30e92b0 to
e1399c3
Compare
|
Hi. I would be very grateful if you release a new update with this fix. Thank you. |
Contributor
Author
|
@Mirzahmet Oops, sorry about that - should be published now, see |
holzgeist
added a commit
to holzgeist/track-processors-js
that referenced
this pull request
Sep 9, 2025
fix: properly bundle for browsers fix: revert code changes Reduce the intensity of the gray "flash" when enabling the `BackgroundProcessor` (livekit#96) Version Packages (livekit#99) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Cache background image (livekit#100) Version Packages (livekit#101) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #91, it seemed like there was some state
backgroundImagethat was previously in the past being used to cache the background image to keep it from being loaded brand new every time the background is shown.So, use this state to cache the image data, plus add a cache key on the path so if the path changes, the image will be refetched - from what I can tell, this wasn't being done properly in the past implementation!
A demo video - performance on my relatively speedy Internet seems about the same between the first and nth background toggles with the same image, but I suspect it would make more of a difference on slower internet:
Untitled.mov