fix(treasury): clarify voting ineligibility for new delegators#441
fix(treasury): clarify voting ineligibility for new delegators#441thebeyondr merged 6 commits intomainfrom
Conversation
- Show Ineligible status instead of disabled buttons when user had no stake at snapshot - Hide null address delegate from UI - Display snapshot date in ineligibility message - Link to LIP-89 for stake snapshot explanation - Restructure widget into Results and Your vote sections - Use thinner, read-only styled vote bars Fixes #301
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR improves the treasury voting widget UX by clarifying voting ineligibility for new delegators who had no stake at the proposal snapshot time. Instead of showing disabled vote buttons (which don't explain why voting is unavailable), the widget now displays an informative banner explaining the eligibility requirements and linking to documentation about stake snapshots. The component is also restructured with clear "Results" and "Your vote" sections for better visual hierarchy.
Key Changes
- Replaced disabled vote buttons with an informative ineligibility banner that explains snapshot-based voting requirements and links to LIP-89 documentation
- Restructured widget into distinct "Results" and "Your vote" sections with uppercase section labels
- Filtered out null address delegates (0x0...0) from the UI display
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ECWireless
left a comment
ECWireless
left a comment
There was a problem hiding this comment.
Basically LGTM! Just left a couple nits. Your code comments were also super helpful
… improve accessibility - Introduced useMemo for calculating user vote status to optimize performance. - Removed hardcoded zero address definition and imported it from 'viem'. - Added 'rel="noopener noreferrer"' to external link for improved security.
Description
Clarifies voting ineligibility for new delegators by replacing disabled buttons with an informative UI explaining why the user cannot vote. Restructures the widget into clear "Results" and "Your vote" sections for better visual hierarchy.
Type of Change
Related Issue
Closes #301
Changes Made
Testing
Screenshots (if applicable)
Checklist