In the PendingStake method of the
BondingManager, the round parameter is currently unused:
|
uint256 endRound = roundsManager().currentRound(); |
To improve clarity and reduce potential confusion for integrators and developers, I propose one of the following actions:
-
Update the method description and documentation to explicitly state that the round parameter is currently unused, and clarify its intended purpose (if any future usage is planned).
-
Upgrade the protocol to make use of the round parameter, if there is an intended use case (e.g., allowing querying of stake at a specific round).
This change will help avoid misinterpretation and make the API more intuitive and self-explanatory for future development and integrations.
In the PendingStake method of the
BondingManager, the
roundparameter is currently unused:protocol/contracts/bonding/BondingManager.sol
Line 935 in e8b6243
To improve clarity and reduce potential confusion for integrators and developers, I propose one of the following actions:
Update the method description and documentation to explicitly state that the
roundparameter is currently unused, and clarify its intended purpose (if any future usage is planned).Upgrade the protocol to make use of the
roundparameter, if there is an intended use case (e.g., allowing querying of stake at a specific round).This change will help avoid misinterpretation and make the API more intuitive and self-explanatory for future development and integrations.