Conversation
Remove mention of linting from CI requirements since it's temporarily disabled until golangci-lint supports Go 1.25. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the contributing guidelines by removing the mention of "linting" from the CI checks requirement. The change clarifies that pull requests need to pass tests and code formatting checks.
- Updated contributing documentation to remove reference to linting checks
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5 tasks
This was referenced Jan 25, 2026
Closed
6 tasks
adnaan
added a commit
that referenced
this pull request
Mar 12, 2026
The core library (livetemplate/livetemplate#179) fixed a bug where range variables in executeRangeBodyWithVars were stored with the $ prefix, causing buildExecData to construct "$$index" patterns that never matched {{$index}} in templates. The fix strips the $ prefix so that pipe expressions like {{$index | printf "#%d"}} now correctly resolve to "#0", "#1", etc. instead of empty strings. Updates all affected golden files: - update_01: Initial range items now have "#0", "#1", "#2" for field 2 - update_02: Adds ["u", "todo-3", {"2": "#1"}] after remove (index shift) - update_03: Adds index updates for completed/reordered items - update_05a: Adds index updates for existing items when prepending - update_05b: Adds index updates for existing items when inserting middle - update_06: Adds index updates for multi-operation scenario Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
adnaan
added a commit
that referenced
this pull request
Mar 13, 2026
* fix: update golden files for corrected $index resolution in range The core library (livetemplate/livetemplate#179) fixed a bug where range variables in executeRangeBodyWithVars were stored with the $ prefix, causing buildExecData to construct "$$index" patterns that never matched {{$index}} in templates. The fix strips the $ prefix so that pipe expressions like {{$index | printf "#%d"}} now correctly resolve to "#0", "#1", etc. instead of empty strings. Updates all affected golden files: - update_01: Initial range items now have "#0", "#1", "#2" for field 2 - update_02: Adds ["u", "todo-3", {"2": "#1"}] after remove (index shift) - update_03: Adds index updates for completed/reordered items - update_05a: Adds index updates for existing items when prepending - update_05b: Adds index updates for existing items when inserting middle - update_06: Adds index updates for multi-operation scenario Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: update go.mod to use merged core library commit Points to squash-merged PR #179 on livetemplate/livetemplate main branch which fixes $index resolution in pipe expressions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick verification that CI workflow runs correctly after merge to main.