Conversation
|
the removal of tests shows that this would be a breaking change. i need to think about this. |
|
@MadManMathew If you're still interested in landing this, could you rebase (not merge) on top of latest master? |
|
@ljharb yes will do |
|
@ljharb I messed up the rebase, will fix. |
|
no worries, just ping me when you'd like me to take a look! |
|
@MadManMathew if you're still interested in landing this, please use my version of your tests (from 75fe7ce) and let's get it working without removing any existing tests. Changing them slightly may end up being fine. |
|
@MadManMathew if you're not interested in completing this PR, would you mind checking the "allow edits" checkbox on the right hand column? |
|
@ljharb sorry will do |
|
I've rebased this and included my tests; but I'm not sure how to adapt your fix to make the tests pass. |
|
@MadManMathew are you interested in pursuing this PR? |
3 participants
#122
let me know your'e thoughts, I know remove test cases isn't ideal but I removed the functionality where we make the value the key and the value of that key true.