Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
==========================================
+ Coverage 55.43% 55.77% +0.33%
==========================================
Files 18 18
Lines 1407 1420 +13
==========================================
+ Hits 780 792 +12
- Misses 627 628 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
Is this not showing up in Aqua because the ambiguity only is there if CUDA is loaded? |
Contributor
Author
|
Yes basically exactly that. |
lkdvos
reviewed
Feb 17, 2026
Contributor
Author
|
lol "amgiguating" |
Contributor
Author
|
Annoying, more ambiguities to fix. |
kshyatt
force-pushed
the
ksh/conversion
branch
from
e5d63ac to
6f44092
Compare
Contributor
Author
|
OK, I think this is ok to go (but we'll want to fix |
lkdvos
reviewed
Feb 20, 2026
lkdvos
reviewed
Feb 20, 2026
lkdvos
reviewed
Feb 20, 2026
Contributor
Author
|
OK, created a more specific |
kshyatt
force-pushed
the
ksh/conversion
branch
from
6f631e0 to
b6ed4ee
Compare
Contributor
Author
|
I think everything got resolved here? |
lkdvos
requested changes
Feb 25, 2026
Contributor
Author
|
Now with a |
kshyatt
commented
Feb 27, 2026
lkdvos
reviewed
Feb 27, 2026
kshyatt
force-pushed
the
ksh/conversion
branch
from
7d8a688 to
2d7ce3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to be needed for conversion of
BlockTensorMaps backed by GPU arrays toCuTensorMap-- otherwise an ambiguity error arises.