build tools/lkl failed

[lamiaaMB]

I'm building the lkl tools on Ubuntu 15, and I'm getting this error when I use the command
make -C tools/lkl

In file included from include/lkl_host.h:8:0,
from lib/posix-host.c:17:
include/lkl/asm/host_ops.h:5:1: error: two or more data types in declaration specifiers
struct lkl_mutex;
^
include/lkl/asm/host_ops.h:5:8: warning: useless type name in empty declaration [enabled by default]
struct lkl_mutex;
^
include/lkl/asm/host_ops.h:5:8: error: ‘inline’ in empty declaration

Regards,

[tavip]

Hi @lamiaaMB , thanks for reporting this. Can you please paste the last 20-30 lines of the build?

[lamiaaMB]

Hi @tavip ,
I'm sorry for being that late, kindly find below the lines you asked for

REPLACE /home/lamiaa/Documents/linux-master/tools/lkl/include/lkl/linux/fcntl.h
REPLACE /home/lamiaa/Documents/linux-master/tools/lkl/include/lkl/linux/poll.h
REPLACE /home/lamiaa/Documents/linux-master/tools/lkl/include/lkl/linux/ioctl.h
REPLACE /home/lamiaa/Documents/linux-master/tools/lkl/include/lkl/linux/fs.h
REPLACE /home/lamiaa/Documents/linux-master/tools/lkl/include/lkl/linux/sembuf.h
REPLACE /home/lamiaa/Documents/linux-master/tools/lkl/include/lkl/linux/ipc.h
REPLACE /home/lamiaa/Documents/linux-master/tools/lkl/include/lkl/linux/socket.h
CC lklfuse.o
LD lklfuse-in.o
CC lib/fs.o
lib/fs.c: In function ‘lkl_get_virtio_blkdev’:
lib/fs.c:145:10: warning: ‘device_id’ may be used uninitialized in this function [-Wmaybe-uninitialized]
*pdevid = device_id;
^
CC lib/iomem.o
CC lib/net.o
CC lib/posix-host.o
In file included from include/lkl_host.h:8:0,
from lib/posix-host.c:17:
include/lkl/asm/host_ops.h:5:1: error: two or more data types in declaration specifiers
struct lkl_mutex;
^
include/lkl/asm/host_ops.h:5:8: warning: useless type name in empty declaration [enabled by default]
struct lkl_mutex;
^
include/lkl/asm/host_ops.h:5:8: error: ‘inline’ in empty declaration
cat: lib/.posix-host.o.d: No such file or directory
/home/lamiaa/Documents/linux-master/tools/build/Makefile.build:77: recipe for target 'lib/posix-host.o' failed
make[1]: *** [lib/posix-host.o] Error 1
Makefile:122: recipe for target 'lib/lkl-in.o' failed
make: *** [lib/lkl-in.o] Error 2
make: Leaving directory '/home/lamiaa/Documents/linux-master/tools/lkl'

[lamiaaMB]

It looks like you don't support ubuntu versions later that 14

[thehajime]

I gave a quick try on my ubuntu 15.04 and 16.04. looks fine both make and make test.
@lamiaaMB could you try to git pull and build again ?

• 15.04

root@f0442989e829:~/linux/tools/lkl# lsb_release -a ; gcc --version; git show
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 15.04
Release:	15.04
Codename:	vivid
gcc (Ubuntu 4.9.2-10ubuntu13) 4.9.2
Copyright (C) 2014 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

commit 5b3fcd5876a7ed31ee44f74bb17d8e6bff85700f
Merge: 84f6a9b 1025f3c1
Author: Octavian Purdila <tavi@cs.pub.ro>
Date:   Mon Feb 20 10:42:31 2017 +0200

    Merge pull request #322 from laijs/host_task_stub
    
    use host_task_stub() for host task

• 16.04

root@zak-docker1:~/lkl/tools/lkl# gcc --version
gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609
Copyright (C) 2015 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

root@zak-docker1:~/lkl/tools/lkl# lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 16.04.1 LTS
Release:        16.04
Codename:       xenial
root@zak-docker1:~/lkl/tools/lkl# git show
commit 84f6a9b4bcb0c17c6c1b5eacccba2f84159b05c4
Merge: 311a4ee 9045528
Author: Octavian Purdila <tavi@cs.pub.ro>
Date:   Thu Feb 16 22:31:46 2017 +0200

    Merge pull request #332 from laijs/lkl/stackoverflow
    
    fix stackoverflow in test_getdents64()

[lamiaaMB]

@thehajime
I've just tried to pull the latest update ( after the merge of the request ) and I still get the same error. when I tried to build on a remote machine that has ubuntu 14 installed on it , it built fine

[thehajime]

please describe a bit more about your environment in order to reproduce this issue.

• ubuntu release (lsb_release -a)
• gcc version
• full build log

did you try to make mrproper before your build ?

[lamiaaMB]

Ubuntu release : 15.10
gcc version : 4.8
The full build and error logs are attached
Yes, I tried make mrproper before building and got the same error

blog.txt
elog.txt

[tavip]

@lamiaaMB could you also please attach an archive of the full tools/lkl directory after the build error?

[lamiaaMB]

kindly find it attached
lkl.zip

[thehajime]

kindly find it attached
lkl.zip

@lamiaaMB looks like you're not using the latest lkl tree according to the file lkl/lib/posix-host.c in your lkl.zip (mutex_alloc() is at least the old one).

one thing that was my mistake is make mrproper doesn't clean the tools/lkl directory. make clean -C tools/lkl instead may help you.

[thehajime]

I gave a try with 15.10 ubuntu, almost fresh install and fresh clone of lkl, and can't reproduce the issue you reported.

[tavip]

@lamiaaMB can you please run the following command after the build fails (with the /home/tavi/... replaced with your paths)

~/src/linux/tools/lkl$ gcc -Wp,-MD,/home/tavi/src/linux/tools/lkl/lib/.posix-host.o.d,-MT,/home/tavi/src/linux/tools/lkl/lib/posix-host.o -I/home/tavi/src/linux/tools/lkl//include -Iinclude -Wall -g -O2 -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -fno-strict-aliasing -fPIC -pthread -DCONFIG_AUTO_LKL_POSIX_HOST -D"BUILD_STR(s)=#s" -D_FILE_OFFSET_BITS=64 -E -o /home/tavi/src/linux/tools/lkl/lib/posix-host.o lib/posix-host.c

and please post /home/tavi/src/linux/tools/lkl/lib/posix-host.o lib/posix-host.c

[lamiaaMB]

@thehajime
I make a new fresh installation and here is the archive after the build failed

lkl.zip