fix: enable_session_persistence in AgentConfig should be optional#1012
Merged
ashwinb merged 2 commits intollamastack:mainfrom Feb 14, 2025
Merged
fix: enable_session_persistence in AgentConfig should be optional#1012ashwinb merged 2 commits intollamastack:mainfrom
ashwinb merged 2 commits intollamastack:mainfrom
Conversation
facebook-github-bot
added
the
CLA Signed
terrytangyuan
requested review from
ashwinb,
dineshyv,
dltn,
ehhuang,
hardikjshah,
raghotham,
sixianyi0721,
vladimirivic and
yanxi0830
as code owners
ashwinb
reviewed
Feb 7, 2025
docs/_static/llama-stack-spec.html
Outdated
Contributor
There was a problem hiding this comment.
Just checking -- did you update this using cd docs/openapi_generator && sh run_openapi_generator.sh?
Contributor
Author
There was a problem hiding this comment.
I removed the unrelated change (accidentally included by my other work)
terrytangyuan
force-pushed
the
fix-bool
branch
from
d959ad5 to
033182e
Compare
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
ashwinb
approved these changes
Feb 14, 2025
Contributor
|
@terrytangyuan I just rebased and resolved the doc generation conflict |
Contributor
Author
|
Thank you! |
ashwinb
pushed a commit
to llamastack/llama-stack-client-python
that referenced
this pull request
Feb 14, 2025
…ev (#145) # What does this PR do? - adapt to llamastack/llama-stack#1012 [//]: # (If resolving an issue, uncomment and update the line below) [//]: # (Closes #[issue-number]) ## Test Plan [Describe the tests you ran to verify your changes with result summaries. *Provide clear instructions so the plan can be easily re-executed.*] [//]: # (## Documentation) [//]: # (- [ ] Added a Changelog entry if the change is significant)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This issue was discovered in #1009 (comment).
Test Plan
This field is no longer required after the change.