Conversation
facebook-github-bot
added
the
CLA Signed
yanxi0830
requested review from
ashwinb,
dineshyv,
dltn,
ehhuang,
hardikjshah,
raghotham,
sixianyi0721,
terrytangyuan and
vladimirivic
as code owners
ashwinb
approved these changes
Feb 20, 2025
yanxi0830
added a commit
to llamastack/llama-stack-client-python
that referenced
this pull request
Feb 20, 2025
…#150) # What does this PR do? - See llamastack/llama-stack#1186 ## Test Plan - Test in llamastack/llama-stack#1186 [//]: # (## Documentation) [//]: # (- [ ] Added a Changelog entry if the change is significant)
yanxi0830
added a commit
that referenced
this pull request
Mar 4, 2025
# What does this PR do? - This was missed from previous deprecation: #1186 - Part of #1396 [//]: # (If resolving an issue, uncomment and update the line below) [//]: # (Closes #[issue-number]) ## Test Plan ``` pytest -v -s --nbval-lax ./llama-stack/docs/notebooks/Llama_Stack_Benchmark_Evals.ipynb ``` [//]: # (## Documentation)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #1088
NOTE: this will be a breaking change. We have introduced the new API in 0.1.3 .
Notebook has been updated to use the new endpoints.
Test Plan
cc @SLR722 for awareness