Conversation
facebook-github-bot
added
the
CLA Signed
yanxi0830
requested review from
SLR722,
ashwinb,
dineshyv,
dltn,
ehhuang,
hardikjshah,
raghotham,
sixianyi0721,
terrytangyuan and
vladimirivic
as code owners
Contributor
terrytangyuan
left a comment
terrytangyuan
left a comment
There was a problem hiding this comment.
Is there any docs around how the recorded responses were generated/updated?
Contributor
Author
@terrytangyuan basically add --record-responses flag LLAMA_STACK_CONFIG=fireworks pytest -v tests/integration/agents/test_agents.py --text-model meta-llama/Llama-3.3-70B-Instruct --record-responses. cc @ehhuang to add some quick docs |
Contributor
|
Will those get updated every time we run? |
Contributor
|
@terrytangyuan the model is that if inference responses need to change, you need to re-record. Otherwise you work off of recorded responses which are stored in files — in that mode, you don’t call inference APIs at all. |
ashwinb
approved these changes
Mar 7, 2025
Contributor
|
Got it. Thanks! Still catching up with recent changes... |
yanxi0830
added a commit
to llamastack/llama-stack-client-python
that referenced
this pull request
Mar 7, 2025
# What does this PR do? - Introduce `AsyncAgent` -- an async version of Agent wrapper using AsyncLlamaStackClient - Enable async def with client_tool decorator - Closes llamastack/llama-stack#1391 ```python class Agent: def create_session(...): ... def create_turn(...): ... class AsyncAgent async def create_session(...): ... async def create_turn(...): ... ``` > NOTE, there's some code duplication to keep the distinction and avoid too many if/else [//]: # (If resolving an issue, uncomment and update the line below) [//]: # (Closes #[issue-number]) ## Test Plan - test with script in: https://github.com/meta-llama/llama-stack-apps/blob/async_agent/examples/agents/async_agent.py - test with ReAct agent ``` pytest -v tests/client-sdk/agents/test_agents.py --inference-model meta-llama/Llama-3.1-8B-Instruct ``` <img width="843" alt="image" src="https://github.com/user-attachments/assets/29c08ff6-4e8e-4ca3-a017-e1445b1648d2" /> - TODO (follow up): add a test case in client-sdk agents test in llama-stack - sync agent test passing in: llamastack/llama-stack#1462 [//]: # (## Documentation) [//]: # (- [ ] Added a Changelog entry if the change is significant)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Test Plan