flatten 2D or 3D array#117
Merged
Merged
Conversation
yjlim5
reviewed
Aug 14, 2017
| if (arr.length === 0) { | ||
| return arr; | ||
| } | ||
| let a = arr.shift(); |
Collaborator
There was a problem hiding this comment.
variable naming- what does a represent?
yjlim5
reviewed
Aug 14, 2017
| } | ||
| let a = arr.shift(); | ||
| if (a.length) { | ||
| a.forEach((elem) => { |
yjlim5
previously requested changes
Aug 14, 2017
Collaborator
yjlim5
left a comment
yjlim5
left a comment
There was a problem hiding this comment.
minor issues with code style
dsope05
dismissed
yjlim5’s stale review
why can't I change the review status, i fixed the comments.
yjlim5
approved these changes
Aug 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
recursive solution