Build separate libraries for MPI mount #640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This may resolve at least part of the problem for issue #548 |
Also: - add rpath support to gotcha and spath m4 - define USE_SPATH for use in source code (HAVE_SPATH is for makefiles) - remove old sysio examples - automake target_LDFLAGS should only be used for linker options, target_LIBADD is suggested for '-L<libpath> -l<lib>' additions
CamStan
approved these changes
Jun 23, 2021
Member
CamStan
left a comment
CamStan
left a comment
There was a problem hiding this comment.
@MichaelBrim, this looks good to me. Nice cleanup!
Do we want/need a note or subsection for building on Cray systems in our docs to mention this? Maybe in the two "...build UnifyFS with autotools" sections, or the "Configure Options" section?
Or is this fairly common knowledge to Cray users?
For Cray systems, you must pass a couple environment variable settings to the configure command for the MPI compiler wrapper detection to work. For example:
configure MPICC=cc MPIFC=ftn
Collaborator
Author
|
@CamStan, I think it is worth adding a note to the build docs. I'll do that. |
TEST_CHECKPATCH_SKIP_FILES=docs/build.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the configure and build process to produce separate libraries that contain our MPI auto-mount capability.
It also includes a few changes to support builds on Cray systems, and removes the old sysio examples.
Motivation and Context
Previously, the behavior of the
libunifyfswith respect to MPI auto-mount was set at configure time, which is not really transparent to users. With these changes, when the user configures with--enable-mpi-mount, we will generate additional libraries with_mpiin the name to clearly indicate that the library has the MPI auto-mount capability.How Has This Been Tested?
Tested on Docker Ubuntu, OLCF Summit and Spock.
For Cray systems, you must pass a couple environment variable settings to the configure command for the MPI compiler wrapper detection to work. For example:
configure <opts> MPICC=cc MPIFC=ftnTypes of changes
Checklist: