Add heartbeat RPC to detect failed clients #653
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The request manager thread for each client will send a periodic heartbeat RPC to the client to make sure it hasn't gone away unexpectedly. Currently, the period is set to 30 seconds. When a failure is detected, the request manager thread will exit and the client state will be cleaned by the main server thread.
Motivation and Context
See issues: #567 #646
How Has This Been Tested?
Tested in Docker Ubuntu by killing one of the unit tests while it was still executing and making sure the failure was detected and cleanup occurred.
Types of changes
Checklist: