Skip to content

Conversation

@wangvsa
Copy link
Collaborator

@wangvsa wangvsa commented May 16, 2023

Description

Add fopen64 wrapper.
The wrapper reuses the internal uniyfs_fopen function, which was implemented for fopen wrapper, with the exception of adding the O_LARGEFILE flag when creating new files.

Motivation and Context

Several 64-bit version wrappers are missing, including fopen64, stat64, fstat64, etc. One known application, Montage, uses those functions (#769).
The documentation on adding new wrappers is outdated. So this PR adds only one wrapper and tries to make sure all necessary files are modified. We can update the doc later if everything works fine.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Testing (addition of new tests or update to current tests)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the UnifyFS code style requirements.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commit messages are properly formatted.

Signed-off-by: Chen Wang <wangvsa@gmail.com>
@kathrynmohror kathrynmohror merged commit 7643ff9 into llnl:dev May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants