Extending Precision for Some DIRK Methods#593
Merged
Conversation
Steven-Roberts
requested review from
balos1,
cswoodward,
drreynolds and
gardner48
as code owners
drreynolds
requested changes
Oct 17, 2024
Collaborator
drreynolds
left a comment
drreynolds
left a comment
There was a problem hiding this comment.
These look great. Can you add a comment to the RecentChanges and CHANGELOG files to state that the precision of these coefficients has been increased?
drreynolds
approved these changes
Oct 17, 2024
gardner48
pushed a commit
that referenced
this pull request
Jul 21, 2025
The Billington, Cash, and Kvaerno DIRK method coefficients only had ~10-14 digits of accuracy which can be insufficient for double and extended precision. This PR extends the coefficients to 40 digits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Billington, Cash, and Kvaerno DIRK method coefficients only had ~10-14 digits of accuracy which can be insufficient for double and extended precision. This PR extends the coefficients to 40 digits.