CMake: Don't clobber un-namespaced options#600
Merged
gardner48 merged 4 commits intollnl:developfrom Dec 3, 2024
Merged
Conversation
ZedThree
requested review from
balos1,
cswoodward,
drreynolds and
gardner48
as code owners
Fixes llnl#538 Non-`SUNDIALS` namespaced variables may be used by other projects so don't `unset` them Signed-off-by: Peter Hill <peter.hill@york.ac.uk>
ZedThree
force-pushed
the
fix-sundials_option
branch
from
a880092 to
edb83d4
Compare
balos1
reviewed
Nov 13, 2024
Member
balos1
left a comment
balos1
left a comment
There was a problem hiding this comment.
Looks good to me. This will make the CMake GUI display options that are irrelevant unless the right ENABLE_* variable is set, but we will have to find a different way to address that.
balos1
approved these changes
Nov 26, 2024
gardner48
pushed a commit
that referenced
this pull request
Jul 21, 2025
Non-`SUNDIALS` namespaced variables may be used by other projects so don't `unset` them. Fixes #538 --------- Signed-off-by: Peter Hill <peter.hill@york.ac.uk> Co-authored-by: Cody Balos <balos1@llnl.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #538
Non-
SUNDIALSnamespaced variables may be used by other projects so don'tunsetthemdevelopbranch notmain.CHANGELOG.mdanddocs/shared/RecentChanges.rstfiles. Notice that the former is a markdown file and the latter is reStructuredText, so the formatting is slightly different.