[IRBuilder] Introduce CreateSelectFMFWithUnknownProfile #174162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This came up in review feedback in c163e7a. This function makes it easier to create select instructions that propagate fast math flags with unknown profile info, which is a common case. This mirrors the already existing CreateSelectWithUknownProfile helper.
llvmbot
added
llvm:instcombine
Member
|
@llvm/pr-subscribers-llvm-transforms Author: Aiden Grossman (boomanaiden154) ChangesThis came up in review feedback in Full diff: https://github.com/llvm/llvm-project/pull/174162.diff 3 Files Affected:
diff --git a/llvm/include/llvm/IR/IRBuilder.h b/llvm/include/llvm/IR/IRBuilder.h
index 972a253344ddf..bc35caabeb849 100644
--- a/llvm/include/llvm/IR/IRBuilder.h
+++ b/llvm/include/llvm/IR/IRBuilder.h
@@ -2553,6 +2553,12 @@ class IRBuilderBase {
StringRef PassName,
const Twine &Name = "");
+ LLVM_ABI Value *CreateSelectFMFWithUnknownProfile(Value *C, Value *True,
+ Value *False,
+ FMFSource FMFSource,
+ StringRef PassName,
+ const Twine &Name = "");
+
LLVM_ABI Value *CreateSelect(Value *C, Value *True, Value *False,
const Twine &Name = "",
Instruction *MDFrom = nullptr);
diff --git a/llvm/lib/IR/IRBuilder.cpp b/llvm/lib/IR/IRBuilder.cpp
index a397f6973ee05..6f7ffe9cbe635 100644
--- a/llvm/lib/IR/IRBuilder.cpp
+++ b/llvm/lib/IR/IRBuilder.cpp
@@ -1014,6 +1014,18 @@ Value *IRBuilderBase::CreateSelectWithUnknownProfile(Value *C, Value *True,
return Ret;
}
+Value *IRBuilderBase::CreateSelectFMFWithUnknownProfile(Value *C, Value *True,
+ Value *False,
+ FMFSource FMFSource,
+ StringRef PassName,
+ const Twine &Name) {
+ Value *Ret = CreateSelectFMF(C, True, False, FMFSource, Name);
+ if (auto *SI = dyn_cast<SelectInst>(Ret)) {
+ setExplicitlyUnknownBranchWeightsIfProfiled(*SI, PassName);
+ }
+ return Ret;
+}
+
Value *IRBuilderBase::CreateSelect(Value *C, Value *True, Value *False,
const Twine &Name, Instruction *MDFrom) {
return CreateSelectFMF(C, True, False, {}, Name, MDFrom);
diff --git a/llvm/lib/Transforms/InstCombine/InstCombineSimplifyDemanded.cpp b/llvm/lib/Transforms/InstCombine/InstCombineSimplifyDemanded.cpp
index 47b66a4e0f37d..3ad1caa6baa63 100644
--- a/llvm/lib/Transforms/InstCombine/InstCombineSimplifyDemanded.cpp
+++ b/llvm/lib/Transforms/InstCombine/InstCombineSimplifyDemanded.cpp
@@ -2202,12 +2202,10 @@ Value *InstCombinerImpl::SimplifyDemandedUseFPClass(Value *V,
Value *X = CI->getArgOperand(0);
Value *IsPosInfOrNan = Builder.CreateFCmpFMF(
FCmpInst::FCMP_UEQ, X, ConstantFP::getInfinity(VTy), FMF);
- Value *ZeroOrInf = Builder.CreateSelectFMF(
- IsPosInfOrNan, X, ConstantFP::getZero(VTy), FMF);
// We do not know whether an infinity or a NaN is more likely here,
// so mark the branch weights as unkown.
- if (auto *SI = dyn_cast<SelectInst>(ZeroOrInf))
- setExplicitlyUnknownBranchWeightsIfProfiled(*SI, DEBUG_TYPE);
+ Value *ZeroOrInf = Builder.CreateSelectFMFWithUnknownProfile(
+ IsPosInfOrNan, X, ConstantFP::getZero(VTy), FMF, DEBUG_TYPE);
return ZeroOrInf;
}
|
Member
|
@llvm/pr-subscribers-llvm-ir Author: Aiden Grossman (boomanaiden154) ChangesThis came up in review feedback in Full diff: https://github.com/llvm/llvm-project/pull/174162.diff 3 Files Affected:
diff --git a/llvm/include/llvm/IR/IRBuilder.h b/llvm/include/llvm/IR/IRBuilder.h
index 972a253344ddf..bc35caabeb849 100644
--- a/llvm/include/llvm/IR/IRBuilder.h
+++ b/llvm/include/llvm/IR/IRBuilder.h
@@ -2553,6 +2553,12 @@ class IRBuilderBase {
StringRef PassName,
const Twine &Name = "");
+ LLVM_ABI Value *CreateSelectFMFWithUnknownProfile(Value *C, Value *True,
+ Value *False,
+ FMFSource FMFSource,
+ StringRef PassName,
+ const Twine &Name = "");
+
LLVM_ABI Value *CreateSelect(Value *C, Value *True, Value *False,
const Twine &Name = "",
Instruction *MDFrom = nullptr);
diff --git a/llvm/lib/IR/IRBuilder.cpp b/llvm/lib/IR/IRBuilder.cpp
index a397f6973ee05..6f7ffe9cbe635 100644
--- a/llvm/lib/IR/IRBuilder.cpp
+++ b/llvm/lib/IR/IRBuilder.cpp
@@ -1014,6 +1014,18 @@ Value *IRBuilderBase::CreateSelectWithUnknownProfile(Value *C, Value *True,
return Ret;
}
+Value *IRBuilderBase::CreateSelectFMFWithUnknownProfile(Value *C, Value *True,
+ Value *False,
+ FMFSource FMFSource,
+ StringRef PassName,
+ const Twine &Name) {
+ Value *Ret = CreateSelectFMF(C, True, False, FMFSource, Name);
+ if (auto *SI = dyn_cast<SelectInst>(Ret)) {
+ setExplicitlyUnknownBranchWeightsIfProfiled(*SI, PassName);
+ }
+ return Ret;
+}
+
Value *IRBuilderBase::CreateSelect(Value *C, Value *True, Value *False,
const Twine &Name, Instruction *MDFrom) {
return CreateSelectFMF(C, True, False, {}, Name, MDFrom);
diff --git a/llvm/lib/Transforms/InstCombine/InstCombineSimplifyDemanded.cpp b/llvm/lib/Transforms/InstCombine/InstCombineSimplifyDemanded.cpp
index 47b66a4e0f37d..3ad1caa6baa63 100644
--- a/llvm/lib/Transforms/InstCombine/InstCombineSimplifyDemanded.cpp
+++ b/llvm/lib/Transforms/InstCombine/InstCombineSimplifyDemanded.cpp
@@ -2202,12 +2202,10 @@ Value *InstCombinerImpl::SimplifyDemandedUseFPClass(Value *V,
Value *X = CI->getArgOperand(0);
Value *IsPosInfOrNan = Builder.CreateFCmpFMF(
FCmpInst::FCMP_UEQ, X, ConstantFP::getInfinity(VTy), FMF);
- Value *ZeroOrInf = Builder.CreateSelectFMF(
- IsPosInfOrNan, X, ConstantFP::getZero(VTy), FMF);
// We do not know whether an infinity or a NaN is more likely here,
// so mark the branch weights as unkown.
- if (auto *SI = dyn_cast<SelectInst>(ZeroOrInf))
- setExplicitlyUnknownBranchWeightsIfProfiled(*SI, DEBUG_TYPE);
+ Value *ZeroOrInf = Builder.CreateSelectFMFWithUnknownProfile(
+ IsPosInfOrNan, X, ConstantFP::getZero(VTy), FMF, DEBUG_TYPE);
return ZeroOrInf;
}
|
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Jan 6, 2026
This came up in review feedback in c163e7a. This function makes it easier to create select instructions that propagate fast math flags with unknown profile info, which is a common case. This mirrors the already existing CreateSelectWithUknownProfile helper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in review feedback in
c163e7a. This function makes it easier to create select instructions that propagate fast math flags with unknown profile info, which is a common case. This mirrors the already existing CreateSelectWithUknownProfile helper.