Fix assert for [CGData] Outlined Hash Tree #89792 #98383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@GuillaumeBelz This is the fix for it. Thanks! |
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
alx32
reviewed
Jul 10, 2024
Comment on lines
122
to
123
| assert(Index + 1 == NodeIdMap.size() && | ||
| "Expected size of NodeMap to increment by 1"); |
Contributor
There was a problem hiding this comment.
Nit: Parens and perhaps a message something like below would give clearer hint on the intent of the assert.
assert((Index + 1 == NodeIdMap.size()) &&
"Expected 'Current' to not already exist in 'NodeIdMap'");
Contributor
Author
There was a problem hiding this comment.
Thanks for the suggestion. I slightly changed the wordings for clarification.
alx32
approved these changes
Jul 10, 2024
aaryanshukla
pushed a commit
to aaryanshukla/llvm-project
that referenced
this pull request
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.