You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This contribution includes a faster implementation of the spectral_layout function. The implementation replaces the eigenvalue compute with a faster MKL based method. The modification provides a speedup of ~9x in some cases.
Important - This modification is dependent on "libmkl_rt.so" library.
While I appreciate the work, and the speedup would be helpful, I am wary of a new dependency on a binary library like this -- I also note you have an environment variable set that is hardcoded to a path that may not be the install location on some machines, and won't work at all on non-Linux machines.
While I appreciate the work, and the speedup would be helpful, I am wary of a new dependency on a binary library like this -- I also note you have an environment variable set that is hardcoded to a path that may not be the install location on some machines, and won't work at all on non-Linux machines.
Hi @lmcinnes ,
We have made the required changes , the environment variable is changed to a dynamic implementation which will work on the on Linux and non-Linux machines. However , we are facing some issues while raising a PR as some pre commit tests aren't passing. Is there a way to run these tests on local environment?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contribution includes a faster implementation of the spectral_layout function. The implementation replaces the eigenvalue compute with a faster MKL based method. The modification provides a speedup of ~9x in some cases.
Important - This modification is dependent on "libmkl_rt.so" library.