Skip to content

Add default timeouts to sync API#124

Merged
ncoghlan merged 3 commits intomainfrom
sync-api-timeouts
Jul 28, 2025
Merged

Add default timeouts to sync API#124
ncoghlan merged 3 commits intomainfrom
sync-api-timeouts

Conversation

@ncoghlan
Copy link
Copy Markdown
Contributor

@ncoghlan ncoghlan commented Jul 25, 2025

Closes #119

@github-actions github-actions bot added the CLA signed Indicates that all contributors have signed label Jul 25, 2025
@ncoghlan
Copy link
Copy Markdown
Contributor Author

In draft due to local failures when testing against the LM Studio server API.

@ncoghlan ncoghlan changed the title WIP: Add default timeouts to sync API Add default timeouts to sync API Jul 28, 2025
@ncoghlan ncoghlan marked this pull request as ready for review July 28, 2025 14:44
@ncoghlan
Copy link
Copy Markdown
Contributor Author

Local failures were due to a test refactoring error (when the default timeout adjustment was split out to a context manager, actually setting the new timeout value was omitted, so only the original test case passed).

@ncoghlan ncoghlan merged commit c6876c6 into main Jul 28, 2025
10 checks passed
@ncoghlan ncoghlan deleted the sync-api-timeouts branch July 28, 2025 14:53
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA signed Indicates that all contributors have signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐞 Bug Report: model.respond() hangs indefinitely without timeout support

1 participant