Add option for users to merge trial accounts with phone-number–linked accounts on upgrade flow#462
Closed
Nodirbek75 wants to merge 2 commits into
Closed
Add option for users to merge trial accounts with phone-number–linked accounts on upgrade flow#462Nodirbek75 wants to merge 2 commits into
Nodirbek75 wants to merge 2 commits into
Conversation
Nodirbek75
added
enhancement
Contributor
|
The PR lnflash/flash#237 sets the PHONE_ACCOUNT_ALREADY_EXISTS_NEED_TO_SWEEP_FUNDS_ERROR correctly now, which the UI is ready expecting. So we will no longer have orphaned accounts, and no need to try and merge when this happens. A better long term solution to this would be to have the UI give the user the option to sweep the funds instead of just giving an error, but this would include them having to choose usernames, npubs, etc. Very complex problem to solve so I think the best solution for now is to block the user from successfully submitting existing account phone numbers @Nodirbek75 Leaving this PR open, so we can discuss more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.