hot-fix with cancelation in waitin-payment status

[Catrya]

Summary by CodeRabbit

• Bug Fixes
  • Improved order cancellation rules: Only sellers can cancel sell orders in "Waiting Payment" status, while buyers can still cancel buy orders in the same status. This enhances security and prevents unauthorized cancellations.

[coderabbitai]

Walkthrough

The cancelOrder function in the order management logic was updated to introduce more precise checks for canceling orders in the WAITING_PAYMENT status. Now, only sellers can cancel sell orders in this state, while buyers can still cancel buy orders, adding role-based control to the cancellation process.

Changes

File(s)	Change Summary
bot/commands.ts	Refined cancelOrder logic: Only sellers can cancel sell orders in WAITING_PAYMENT; buyers can cancel buy orders. No changes to public/exported declarations.

Poem

A bunny with orders to tend,
Tweaked the rules so sellers defend—
Only they can cancel a sell,
While buyers cancel theirs as well.
With careful checks, the bot’s now wise,
Guarding trades with rabbit eyes! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 2d01bde and ced223b.

📒 Files selected for processing (1)

• bot/commands.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• bot/commands.ts

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: ci_to_main
• GitHub Check: Analyze (javascript)
• GitHub Check: ci_to_main

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

bot/commands.ts (1)

625-633: Good improvement: Added role-based authorization for sell orders in WAITING_PAYMENT status.

This change adds an important security check to ensure that only sellers can cancel their sell orders in the WAITING_PAYMENT status. The implementation correctly fetches the seller user document and compares Telegram IDs to verify the user's identity before allowing the cancellation.

Consider adding a comment explaining why only sellers should be able to cancel sell orders in this state, similar to the comment for the buy order case. This would improve code maintainability by making the business logic more explicit.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6df44bf and 2d01bde.

📒 Files selected for processing (1)

• bot/commands.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Analyze (javascript)
• GitHub Check: ci_to_main
• GitHub Check: ci_to_main

🔇 Additional comments (1)

bot/commands.ts (1)

619-623: LGTM: Proper cancel logic for buy orders in WAITING_PAYMENT status.

This segment correctly handles the case where a seller is taking a buy offer and accidentally touches the continue button, allowing them to cancel the order when it's in WAITING_PAYMENT status.

[grunch]

tACK