Skip to content

Remove .rspec_status from the gem bundle#64

Merged
loadkpi merged 1 commit into
loadkpi:masterfrom
rwojsznis:exclude-rspec-status
Apr 28, 2026
Merged

Remove .rspec_status from the gem bundle#64
loadkpi merged 1 commit into
loadkpi:masterfrom
rwojsznis:exclude-rspec-status

Conversation

@rwojsznis
Copy link
Copy Markdown
Contributor

  • Simplify spec.files in the gemspec so package includes only required files
  • Remove and add .rspec_status to .gitignore as by accident it was part of the gem

Hey there 👋 I was looking at my CI bundle cache size as looking for biggest offenders and noticed that this gem adds unnecessary 17MB rspec status file - seems it was added by accident in #57

Comment thread crawler_detect.gemspec
Comment thread crawler_detect.gemspec
@rwojsznis rwojsznis marked this pull request as ready for review April 26, 2026 18:57
@rwojsznis
Copy link
Copy Markdown
Contributor Author

Oh, seems like some test fails - probably due to rack and legacy ruby incompatibility 🤔

An error occurred while loading ./spec/rack_spec.rb.
Failure/Error: require "rack/test"

TypeError:
  wrong element type String at 0 (expected array)
# ./vendor/bundle/ruby/2.5.0/gems/rack-3.2.6/lib/rack/utils.rb:149:in `to_h'

Doesn't seems to be related to the change itself tho; this Ruby EOLed a while back so maybe there is no point of running tests on such old version 🤷 (out of scope of this PR ofc 😅 )

@loadkpi
Copy link
Copy Markdown
Owner

loadkpi commented Apr 28, 2026

Oh, seems like some test fails - probably due to rack and legacy ruby incompatibility 🤔

An error occurred while loading ./spec/rack_spec.rb.
Failure/Error: require "rack/test"

TypeError:
  wrong element type String at 0 (expected array)
# ./vendor/bundle/ruby/2.5.0/gems/rack-3.2.6/lib/rack/utils.rb:149:in `to_h'

Doesn't seems to be related to the change itself tho; this Ruby EOLed a while back so maybe there is no point of running tests on such old version 🤷 (out of scope of this PR ofc 😅 )

fixed in #65

I prefer to run with old versions to make sure it has backward compability

Please make a rebase

- Simplify `spec.files` in the gemspec so package includes only required files
- Remove and add `.rspec_status` to `.gitignore` as by accident it was part
of the gem
@rwojsznis rwojsznis force-pushed the exclude-rspec-status branch from c83ff0e to 876c416 Compare April 28, 2026 09:58
@loadkpi loadkpi merged commit 5594b48 into loadkpi:master Apr 28, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants