Skip to content

BGSTB-328 | Fix error on GET letters with tracking events#189

Merged
hpelletier merged 4 commits intomainfrom
bgstb-328/letters-tracking-events-fix
Jul 1, 2025
Merged

BGSTB-328 | Fix error on GET letters with tracking events#189
hpelletier merged 4 commits intomainfrom
bgstb-328/letters-tracking-events-fix

Conversation

@hpelletier
Copy link
Copy Markdown
Contributor

@hpelletier hpelletier commented Jun 27, 2025

Description

  • Remove faulty validation logic in the setTrackingEvents function for letters
  • Update the run_tests.yml file to get unit tests running in pull requests
  • Add a null check in LettersApi in order to get all unit tests passing

Story

https://lobsters.atlassian.net/browse/BGSTB-328

@hpelletier hpelletier force-pushed the bgstb-328/letters-tracking-events-fix branch from 256ae43 to b91149b Compare June 27, 2025 20:52
@hpelletier hpelletier force-pushed the bgstb-328/letters-tracking-events-fix branch from 3a4faa1 to 0cebb17 Compare June 27, 2025 21:01
@hpelletier hpelletier changed the title BGSTB-328 BGSTB-328 | Fix error on GET letters with tracking events Jun 27, 2025
@hpelletier hpelletier marked this pull request as ready for review June 27, 2025 21:43
Copy link
Copy Markdown

@kevinpjones kevinpjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hpelletier hpelletier merged commit 2c235e4 into main Jul 1, 2025
3 checks passed
@hpelletier hpelletier deleted the bgstb-328/letters-tracking-events-fix branch July 1, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants