Skip to content

fix: catch multiple of issue for decimals #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BennyKitchell merged 2 commits into from
Nov 21, 2022
Merged

fix: catch multiple of issue for decimals #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56417c4
fix: catch multiple of issue for decimals
BennyKitchell Nov 21, 2022
63bd210
fix: fix cap error in zip code error verification
BennyKitchell Nov 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions lob_python/model_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -914,16 +914,22 @@ def check_validations(
current_validations = validations[input_variable_path]
if (is_json_validation_enabled('multipleOf', configuration) and
'multiple_of' in current_validations and
isinstance(input_values, (int, float)) and
not (float(input_values) / current_validations['multiple_of']).is_integer()):
# Note 'multipleOf' will be as good as the floating point arithmetic.
raise ApiValueError(
"Invalid value for `%s`, value must be a multiple of "
"`%s`" % (
input_variable_path[0],
current_validations['multiple_of']
)
)
isinstance(input_values, (int, float))):
# since floating point arithmetic can be imprecise, we'll convert input_values to string
# and determine whether the decimal place is in a value position (within 3 spots of the end of the string)
try:
decimal_index = str(input_values).index('.')
if decimal_index < len(str(input_values)) - 3:
raise ApiValueError(
"Invalid value for `%s`, value must be a multiple of "
"`%s`" % (
input_variable_path[0],
current_validations['multiple_of']
)
)
except:
# if no decimal, then it's a multiple of 0.01
print("whole dollar amount")

if (is_json_validation_enabled('maxLength', configuration) and
'max_length' in current_validations and
Expand Down
3 changes: 2 additions & 1 deletion test/Integration/test_zip_lookups_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,8 @@ def test_lookup_error(self):

with self.assertRaises(Exception) as context:
self.api.lookup(zip)
self.assertTrue("invalid ZIP code" in context.exception.__str__())
print(context.exception.__str__())
self.assertTrue("invalid zip code" in context.exception.__str__())


if __name__ == '__main__':
Expand Down