Error on fresh install

[rupertj]

We just need to check this array index exists before using it.

[rupertj]

Actually, this isn't just a case of checking the array exists. Our hook in the profile needs to run after the system module hook that provides the data we change, and for some reason on my install it's not. Changing the order of the hooks so ours is consistently after system fixes this.

[andybroomfield]

I'm not encountering this, on a fresh install though both drush si localgov -y and though the UI installer, deleting the database between each.

This is on Drupal 10.5.3

Any other modules being enabled along with the profile? Something that would clear out the page attachments array?

[rupertj]

The site's on platform.sh, and was installed via the UI. I don't think there's any other modules that could be causing this error, as I was copying the setup from another site that doesn't have this problem, but this is what it has on it:

  "require": {
    "composer/installers": "^2.0",
    "drupal/ai_provider_aws_bedrock": "^1.1@beta",
    "drupal/core-composer-scaffold": "^10.0",
    "drupal/core-project-message": "^10.0",
    "drupal/core-recommended": "^10.0",
    "drupal/redis": "^1.6",
    "drush/drush": "^12",
    "localgovdrupal/localgov": "^3.1",
    "localgovdrupal/localgov_publications_importer": "dev-feature/1.x/28-background-processing",
    "platformsh/config-reader": "^2.4"
  },

[andybroomfield]

Running xDebug I inserted this code in the profile

function localgov_module_implements_alter(&$implementations, $hook) {
  if ($hook == 'page_attachments') {
    // Move bhcc events plus to last hook.
    $implementated_modules = array_keys($implementations);
  }
}

and inspected which modules where implementing the page_attachements hook.

I see that the order is 'contextual, system, localgov'.
Are you able to do a similar thing in the environment where the site installs and see what the order is.
Does platform.sh do any alterations in the install process. I see redis there which suggests they might be something in the key_value store that drupal uses.

To adjust the order we can implement the above and unset / reset it and see if that works.

unset($implementations['localgov']);
$implementations['localgov'] = NULL;

It's certainly an odd scenario.

[andybroomfield]

Thinking about it, this should be implementing hook_page_attachments_alter instead, which would be after all page attachments have been added.

[rupertj]

I think that makes sense. I'm pretty sure that when I made the first version of this feature it used that hook...

[rupertj]

It did! https://github.com/localgovdrupal/localgov_core/pull/177/files

(That PR got closed in favour of one against the profile instead...)

[markconroy]

With #904 merged, can we close this issue?