fix: supress phpstan errors on drupal.org #427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybroomfield
approved these changes
Sep 9, 2025
Contributor
andybroomfield
left a comment
andybroomfield
left a comment
There was a problem hiding this comment.
Looks good to me!
Contributor
finnlewis
deleted the
fix/1.x/supress-phpstan-group-alert-banner-errors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This will supress the PHPStan errors on Drupal.org due to localgov_microsites_group and it not being a composer dev dependency (https://git.drupalcode.org/project/localgov_alert_banner/-/jobs/6424731).
It is unlikely we'd want to have this module as a dev dependency due to the volume of other modules it would bring in.
Workflow testing errors are not due to this PR and are fixed by #426