Skip to content

fix eslint issues #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
finnlewis merged 1 commit into from
Nov 18, 2025
Merged

fix eslint issues #429

finnlewis merged 1 commit into from
Nov 18, 2025

Conversation

@markconroy
Copy link
Member

@markconroy markconroy commented Oct 20, 2025

Closes #428

finnlewis
finnlewis approved these changes Nov 18, 2025
View reviewed changes
Copy link
Member

@finnlewis finnlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I've tested locally and the alert banners function well, so looks good to me!

Thanks @markconroy :)

@finnlewis
Copy link
Member

finnlewis commented Nov 18, 2025

@andybroomfield look OK ?

andybroomfield
andybroomfield approved these changes Nov 18, 2025
View reviewed changes
Copy link
Contributor

@andybroomfield andybroomfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @markconroy

@finnlewis finnlewis merged commit 767bbd8 into 1.x Nov 18, 2025
17 checks passed
@finnlewis finnlewis deleted the fix/428-eslint branch November 18, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@finnlewis finnlewis finnlewis approved these changes

@andybroomfield andybroomfield andybroomfield approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix eslint issues

4 participants

@markconroy @finnlewis @andybroomfield