Skip to content

Conversation

@markconroy
Copy link
Member

Closes #579

What does this change?

  1. Sets .layout__region and .field--table to max-width: 100%, so they don't overflow with any tables (or other elements)
  2. Sets the .tablefield-wrapper to use overflow-x: auto so if it's too wide, it will have a horizonal scroll.

How to test

  1. Visit /test-subsite-demo-all-components/example-page-tables-and-tabs on a small screen and check that only the table has horizontal scroll, not the whole page.

Thanks to Big Blue Door for sponsoring my time to work on this.

@msayoung
Copy link
Member

@markconroy - this isn't working on Chrome and Edge, though is fine on FF.

Not sure how but in DevTools the css is

.tablefield-wrapper {
    overflow-inline: auto;
}

which isn't a thing.

@finnlewis
Copy link
Member

@markconroy @msayoung : This does work for me on Chrome and Firefox, Mac.

image

Copy link
Member

@finnlewis finnlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this works, certainly an improvement, but worth testing in other browsers perhaps?

@finnlewis
Copy link
Member

Discussing in Merge Tuesday, we're going to merge and come back to fix things for Chrome @msayoung if neeeded.

@finnlewis finnlewis merged commit 646a9bc into 1.x Nov 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve CSS on tables

4 participants