Update grid for items to fill space on small screen #789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameronline
approved these changes
May 29, 2025
Member
Author
|
Just a note for Merge Tuesday, the person approving this is Samer Ali, a developer with Big Blue Door. I got him to test it on a few of their sites and it's working as expected. Would be good to get this merged and a new release out. Just leaving this note here as I will not be at Merge Tuesday. |
finnlewis
approved these changes
May 29, 2025
Member
finnlewis
left a comment
finnlewis
left a comment
There was a problem hiding this comment.
I tested this locally and it helped!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #788
What does this change?
A slightly better way to make sure things take up 100% of their container on small screens without horizontal scrolling being added if there's a large
gapset.How to test
Without this patch, set
--grid-column-spacingto3rem, visit a page on a small screen and check if there's any horizontal scroll.Checkout this branch, and the horizontal scrolling should be gone.