Skip to content

Wrap icon and text in <a> tag #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tonypaulbarker merged 6 commits into from
Aug 12, 2025
Merged

Wrap icon and text in <a> tag #790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a8b50ef
Wrap icon and text in <a> tag
markconroy May 28, 2025
902b854
Merge branch '2.x' into feature/787-clickable-link
markconroy Jul 14, 2025
36bb6ab
Allow whole link component to be clickable when in button style
markconroy Jul 14, 2025
cabf149
Allow whole link component to be clickable
markconroy Jul 14, 2025
fc62611
Merge branch '2.x' into feature/787-clickable-link
markconroy Aug 12, 2025
419bf48
CSS coding standard fix
markconroy Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions css/components/link.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,19 @@
.link-wrapper {
position: relative;
display: flex;
align-items: center;
Copy link
Contributor

@ctorgalson ctorgalson Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the only content of .link-wrapper is .link-content, I think line 3 is superfluous, and line 4 belongs after line 8.

}

.link-content > a {
display: flex;
}

.link-content > a::after {
position: absolute;
inset: 0;
content: "";
}

.link-icon {
flex-shrink: 0;
margin-inline-end: var(--link-icon-margin);
Expand Down
10 changes: 5 additions & 5 deletions templates/paragraphs/paragraph--localgov-link.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,13 @@

{% if paragraph.localgov_url.value %}
<div class="link-wrapper">
{% include "@localgov_base/includes/icons/icon.html.twig" with {
icon_name: title_icon,
icon_classes: 'link-icon',
}
%}
<div class="link-content">
<a href="{{ content.localgov_url.0 }}">
{% include "@localgov_base/includes/icons/icon.html.twig" with {
icon_name: title_icon,
icon_classes: 'link-icon',
}
%}
{{ content.localgov_title.0 }}
</a>
</div>
Expand Down