Move theme settings into fieldsets and containers #813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msayoung
reviewed
Jul 1, 2025
localgov_base.theme
Outdated
| // Add settings in a details element for better organization | ||
| $form['localgov_base_settings'] = [ | ||
| '#type' => 'details', | ||
| '#title' => t('LocalGov Base Settings'), |
Member
There was a problem hiding this comment.
This title get's inherited by the child themes. Should it change to the current theme name?
Member
Author
There was a problem hiding this comment.
Updated, good suggestion.
| // Create a fieldset for content status related settings | ||
| $form['localgov_base_settings']['content_status_fieldset'] = [ | ||
| '#type' => 'fieldset', | ||
| '#title' => t('Content Status Display'), |
Member
There was a problem hiding this comment.
I'm not sure about this heading , but I can't think of a better one! :)
Member
Author
There was a problem hiding this comment.
It's just a string. Let's leave it for now and we can easily change it later if we think of a better one.
Member
Author
|
@msayoung @tonypaulbarker This is ready for another review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #791
What does this change?
How to test
Change some settings, make sure they take effect and other settings do not break.
How can we measure success?
We have a tidier settings for for localgov_base and subthemes of it.
Have we considered potential risks?
Settings for current sites break (this should not happen).
Images