places site-slogan inside .branding class

[markconroy]

Closes #869

What does this change?

places site-slogan inside .branding class to it properly follows our BEM naming conventions.

---

Thanks to Big Blue Door for sponsoring my time to work on this.

[simonmwhite]

Hi Mark.

I have reviewed the MR and it looks fine to me apart from the Twig template is using tabs instead of spaces which does not follow Drupal Coding Standards.

Here's what I did to test and what I found. I can see that the logo and slogan are now within .branding class and there is an update to the conditional logic.

I have:

• reviewed the MR
• tested toggling the slogan and logo

Recommendation:

• fix the DCS issue

Thank you.

[markconroy]

Thanks @simonmwhite

Can you mark this as approved if you're okay with it?

I'm not sure why GitHub is reporting tabs instead of spaces, I have my editor set to spaces, and the file is reporting spaces locally.

If it's an issue after we merge it, we can create a follow-up to fix that then.

[simonmwhite]

Hi @markconroy.

Thanks for sharing the screenshot, I can see you're IDE setup as I'd expect so no worries there. I am going to approve the PR.

@tonypaulbarker and @FinnERLewis one thing that came to mind is that that we do not know which councils have already filled out the slogan and have set this to not show, I'd expect the conditional logic around branding__item--slogan to protect it from showing, that and the config setting. I've not tested this scenario so we could potentially see it appear.

Thank you.

[simonmwhite]

I could see from @markconroy screenshot two spaces are set in his IDE. I am approving this PR.