Drupal 11 test failures

[stephen-cox]

 There were 5 errors:

1) Drupal\Tests\localgov_homepage_paragraphs\Functional\HomepageAddTest::testCreateHomepage
Drupal\Core\Config\UnmetDependenciesException: Configuration objects provided by <em class="placeholder">localgov_homepage_paragraphs</em> have unmet dependencies: <em class="placeholder">field.field.paragraph.localgov_featured_campaign.localgov_featured_campaign_image (media.type.image)</em>

/var/www/html/web/core/lib/Drupal/Core/Config/UnmetDependenciesException.php:100
/var/www/html/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:581
/var/www/html/web/core/lib/Drupal/Core/ProxyClass/Config/ConfigInstaller.php:132
/var/www/html/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:209
/var/www/html/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:511
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:541
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:353

2) Drupal\Tests\localgov_subsites_paragraphs\Functional\SubsitesParagraphsAdministrationTest::testSubsiteParagraphsTypes
Drupal\Core\Config\UnmetDependenciesException: Configuration objects provided by <em class="placeholder">localgov_paragraphs</em> have unmet dependencies: <em class="placeholder">core.entity_view_display.paragraph.localgov_contact.default (filter.format.wysiwyg)</em>

/var/www/html/web/core/lib/Drupal/Core/Config/UnmetDependenciesException.php:100
/var/www/html/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:581
/var/www/html/web/core/lib/Drupal/Core/ProxyClass/Config/ConfigInstaller.php:132
/var/www/html/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:209
/var/www/html/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:511
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:541
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:353
/var/www/html/web/modules/contrib/paragraphs/tests/src/Functional/WidgetLegacy/ParagraphsTestBase.php:56

3. Drupal\Tests\localgov_paragraphs\Functional\ContactEditTest::testContactPageComponentEditPage
   Drupal\Core\Config\UnmetDependenciesException: Configuration objects provided by localgov_paragraphs have unmet dependencies: core.entity_view_display.paragraph.localgov_contact.default (filter.format.wysiwyg)

/var/www/html/web/core/lib/Drupal/Core/Config/UnmetDependenciesException.php:100
/var/www/html/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:581
/var/www/html/web/core/lib/Drupal/Core/ProxyClass/Config/ConfigInstaller.php:132
/var/www/html/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:209
/var/www/html/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:511
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:541
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:353
/var/www/html/web/modules/contrib/localgov_paragraphs/tests/src/Functional/ContactEditTest.php:49

4. Drupal\Tests\localgov_paragraphs\Functional\ParagraphsAdministrationTest::testParagraphsTypes
   Drupal\Core\Config\UnmetDependenciesException: Configuration objects provided by localgov_paragraphs have unmet dependencies: core.entity_view_display.paragraph.localgov_contact.default (filter.format.wysiwyg)

/var/www/html/web/core/lib/Drupal/Core/Config/UnmetDependenciesException.php:100
/var/www/html/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:581
/var/www/html/web/core/lib/Drupal/Core/ProxyClass/Config/ConfigInstaller.php:132
/var/www/html/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:209
/var/www/html/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:511
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:541
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:353
/var/www/html/web/modules/contrib/paragraphs/tests/src/Functional/WidgetLegacy/ParagraphsTestBase.php:56

5. Drupal\Tests\localgov_paragraphs\Functional\ParagraphsAdministrationTest::testParagraphsCreation
   Drupal\Core\Config\UnmetDependenciesException: Configuration objects provided by localgov_paragraphs have unmet dependencies: core.entity_view_display.paragraph.localgov_contact.default (filter.format.wysiwyg)

/var/www/html/web/core/lib/Drupal/Core/Config/UnmetDependenciesException.php:100
/var/www/html/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:581
/var/www/html/web/core/lib/Drupal/Core/ProxyClass/Config/ConfigInstaller.php:132
/var/www/html/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:209
/var/www/html/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:511
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:541
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:353
/var/www/html/web/modules/contrib/paragraphs/tests/src/Functional/WidgetLegacy/ParagraphsTestBase.php:56

[millnut]

This is reproducible using 11.2.0-beta1 or 11.2.0-rc1, it also prevents installing the localgov profile via the install ui

[millnut]

I've filed a core bug https://www.drupal.org/project/drupal/issues/3529670 as Drupal 10.4.x, 11.1.x are fine, and this only affects Drupal 11.2.x and I can see nothing in the changelog that could cause this.

[millnut]

Yesterday evening I found the commit on drupal/core which introduced this failure on Drupal 11.2 (all info in the core issue ticket above)

[stephen-cox]

@millnut @finnlewis @ekes I think I know what's going on here.

The configuration in some paragraphs requires optional media configuration in the media module. To fix this sort of thing before we have added code to install optional media config in a hook_modules_installed hook (localgovdrupal/localgov_core@ccbead2). This hook looks to be called in Drupal 11.1.x but not in 11.2.x.

Whether this is the source of the problem or not, having config in install depend on config in optional is clearly not a good thing anyway, but the config in media has always been problematic. See localgovdrupal/localgov_core#130 and localgovdrupal/localgov_core#161

[stephen-cox]

Further to my last comment, it looks to me like the calculation of configuration dependencies is being done before the media module is installed and is failing before any hook_modules_installed hooks are being called.

[stephen-cox]

@tonypaulbarker This is the main issue where we're discussing the Drupal 11.2 test failures

[tonypaulbarker]

@stephen-cox @millnut just to let you know I started looking at localgovdrupal/localgov_core#308 we can see how that goes

[millnut]

@tonypaulbarker this PR #257 enforcing testing with the localgov profile fixes this. This should be an ok fix for now while we look at moving the profile over to recipes in future.

These further PRs are required to fix 11.2 issues fully:

• fix: add container_rebuild_required true to support installing on Drupal 11.2 localgov_core#316
• fix: add container_rebuild_required true to support installing on Drupal 11.2 localgov_services#314
• fix: [3.2.x] failing phpunit test localgov#882
• Rebuild the container when installing the module localgov_topics#35