-
Notifications
You must be signed in to change notification settings - Fork 6
Check image style exists for call out box #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check image style exists for call out box #125
Conversation
Fix #124 If the image style `large_21_9` insn't present, use the full url of the image.
e883305 to
d3bf971
Compare
|
Couple of questions:
|
|
The call out box is used by subsites. Ideally this should be configurable, and we don't seem to encounter other issues as the other image and media styles are in config and are only an issue on initial install. Given this renderes as a background image, either a background image field formatter or loading the set image style from the media display would be the better way forward. This PR is just to solve the initial bug though, so I'd like to move forward with it (Impact should be none form those who keep the image style around). For now we can then use our own theme preproccess hook to put the correct style in. |
|
@ekes will take a look at this with respect to config for image styles |
|
localgovdrupal/localgov_core#162 (comment) oof I say get this in to stop breaking stuff and start a wider discussion on localgov_core/localgov_media |
finnlewis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. Looks good to me too!
|
Thanks all, yes, lets look at image styles seperatly. |
Fix #124
If the image style
large_21_9isn't present, use the full url of the image.