Delete action for a Service Landing page or Service Sub Landing Page can trigger a PHP error.

[marcopagliarulo]

What does this change?

The PR fix the definition of

• $form['localgov_services_navigation_children']['#wrapper_attributes']['class']
• $form['localgov_services_navigation_children']['#attached']['library']

They must be array of string, not string.

How to test

1. Open Content page
2. select any Service Landing page or a Service Sub Landing Page
3. Try to delete the content from the Operations dropdown.
4. The confirmation Modal should be shown regularly without any error.

How can we measure success?

The error message "Oops, something went wrong. Check your browser's developer console for more details." Is not shown and the confirmation dialog is shown.

Have we considered potential risks?

No risks, it's a simple coding issue.

Related Issue

#328

[andybroomfield]

@localgovdrupal/maintainers how do I re-run the tests here. This issue fixes a quite major bug (can't delete landing and sub landing pages).

[andybroomfield]

Thanks @marcopagliarulo.
I've tested this and pages can now be deleted with modal.

I don't think we need a separate test for deleting pages as that's standard Drupal unless we feel that's something we can benefit from, but we need to re-run the tests on this PR before merging.

[andybroomfield]

@localgovdrupal/maintainers I added a commit and force pushed a reset. That gave me the button to approve the workflow to run.