Fail when debug functions are committed.

[rupertj]

There was an issue on localgov_openreferral recently, caused by xdebug_break() being in some committed code. (See localgovdrupal/localgov_openreferral#70).

We could add a check for this and other debug functions using phpcs, like this: https://matthewdaly.co.uk/blog/2017/11/06/catching-debug-statements-in-php/

[millnut]

Thanks for the flag @rupertj agree we should fail on stuff like this, most is caught in phpstan by the https://github.com/spaze/phpstan-disallowed-calls package. I've created spaze/phpstan-disallowed-calls#341 to have them add it to the list so it doesn't end up in production code.

I'll also look at the PHPCS rule in the meantime

[millnut]

This is now handled by localgovdrupal/localgov_project#216 and localgovdrupal/localgov_project#217

[millnut]

Closing this issue, as this has been fixed the in the PRs above