Add theme hook to set the options in Visual theme (Colourways) field

[andybroomfield]

The sub sites visual theme (colourways) worked at BHCC by adding a class to the body field and the colours handled in the theme stylesheet. Assuming its going to be simmilar for sub sites, that themes need to provide the styles to alter the colour scheme, themes are going to need a way of adding values to this field.
This so is content designers can choose visual themes for the sub site that the theme supports.
My initial suggestion is to provide a theme hook, eg. hook_theme_subsites_visual_theme(&$values) which should provide the an array with the class name and the label for the field colourway_classname => Colour way Labal.
eg.

function localgov_theme_subsites_visual_theme(&$values) {
  $values += [
     'localgov_theme_magenta' => 'Magenta',
     'localgov_theme_cyan' => 'Cyan',
     'localgov_theme_rose' => 'Roase',
  ];
}

Pass by reference so child themes can set there own, or unset previous values.
Eg. for the BHCC Theme.

function localgov_bhcc_theme_subsites_visual_theme(&$values) {
  unset($values['localgov_theme_magenta'];
  $values += [
     'localgov_theme_bhcc_magenta' => 'BHCC Magenta',
     'localgov_theme_bhcc_orange' => 'BHCC Orange',
     'localgov_theme_bhcc_corporate' => 'BHCC Corporate',
  ]; 
}

[andybroomfield]

I think this is still a live issue, in that subsites are not currently use the colour scheme field unless confiqured.

[stephen-cox]

This just came up at the Tech Drop-in. There's a theme field that doesn't seem to do anything.

We should either implement this functionality or remove it. If there's work using this in Subsites Extras perhaps we should port that work to this module instead of having it in a separate module.

[andybroomfield]

I think theme field is meant for each site to fill in values.
On BHCC, this adds a body class which the CSS then picks up to theme the site. I'm pretty sure that comes from the module and not our theme...

[stephen-cox]

I can't see any evidence of the localgov_subsites_theme field being added as a body class.

There is code for this is Subsites Extras

https://github.com/localgovdrupal/localgov_subsites_extras/blob/014e0a189de1ef624f5e305112abf04d48c4dfb2/localgov_subsites_extras.module#L10-L28

[andybroomfield]

Your right, It's in our custom module

/**
 * Implements hook_preprocess_html().
 */
function bhcc_subsites_preprocess_html(&$variables) {

  // Route match service.
  $route_match = \Drupal::service('current_route_match');

  // Localgov Subsites api service.
  $subsite_service = \Drupal::service('localgov_subsites.subsite');

  if ($route_match->getParameters()->has('node') && $node = $route_match->getParameter('node')) {

    // If it is the int version (revisions)
    if (!$node instanceof NodeInterface) {
      $node = Node::load((int) $node);
    }

    // If it is a valid subsite.
    if ($subsite = $subsite_service->getSubsite($node)) {

      // If there is a theme selected, add it here.
      if ($subsite->hasField('localgov_subsites_theme')) {
        $subsite_theme = $subsite->localgov_subsites_theme->value;
        $variables['attributes']['class'][] = 'subsite-theme--' . $subsite_theme;
      }
    }

  }
}

[msayoung]

There is this function in the localgov_subsites.module:

function localgov_subsites_preprocess_page(&$variables) {
  $node = \Drupal::routeMatch()->getParameter('node');

  if (!$node instanceof NodeInterface) {
    return;
  }

  if (in_array($node->bundle(), [
    'localgov_subsites_overview',
    'localgov_subsites_page',
  ], TRUE)) {
    $subsite = \Drupal::service('class_resolver')
      ->getInstanceFromDefinition(Subsite::class)
      ->getSubsite($node);

    if ($subsite instanceof NodeInterface && isset($subsite->localgov_subsites_theme->value) && $theme = $subsite->localgov_subsites_theme->value) {
      $variables['attributes']['class'][] = str_replace('_', '--', $theme);
    }
  }
}

but it doesn't seem to work. Using Andy's instead does work.

[markconroy]

I'm going to close this issue as the Subsites Extras module gives us this functionality, and adds a class to the body element such as subsite-extra--color-github.

Feel free to re-open if you think there is further work to do.

Here's an example:

[msayoung]

@markconroy

IMO I don't think this should be closed. The functionlality exists on subsites as it stands, so either

• we remove the functionality and point to subsites extras OR
• make this work

[willguv]

Is this a good time to consider pulling subsites extras into subsites?

It seems like most councils will use it, and finding out about this extra functionality/ asking for it to be installed shouldn't be additional work for them

@msayoung @markconroy

[msayoung]

Well, there is an interesting conundrum...

I think the theme bits can be ported in almost as-is.

One of the features of localgov_subsites_extras is that it uses menus to create the subsite navigation. the main localgov_subsites module does not, and follows the localgovdrupal-y convention of creating heirachry through relationships.

The menu version is much more flexible and allows all sorts of content to be brought in to a subsite.

It would be / is weird to have both going on at once.

[andybroomfield]

Given there is quite a bit of divergence between how these work I wouldn't do that in the current 2.x version.
But I would consider merging subsites and extra in 3.x and make the way extra works with the menu the default way in subsites 3. Perhaps with a fall back to entity hierarchy for backward compatibility (or upgrade existing ones with a menu).

[willguv]

Copying @rupertj and @justinepocock as we've talked about this before, and @tonypaulbarker @finnlewis for info