feat(svelte): auto-destroy haptics on unmount#33
Open
shizukushq wants to merge 1 commit intolochie:mainfrom
Open
feat(svelte): auto-destroy haptics on unmount#33shizukushq wants to merge 1 commit intolochie:mainfrom
shizukushq wants to merge 1 commit intolochie:mainfrom
Conversation
|
@shizukushq is attempting to deploy a commit to the Lochie Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Svelte usage currently requires manual cleanup with
onDestroy(destroy).This moves that cleanup into
createWebHaptics, so the Svelte wrapper handles instance cleanup automatically on component unmount.Also updates the Svelte example and docs snippet to match.