Implement rapidcheck for variant spec#3
Merged
lockshaw merged 14 commits intolockshaw:dtgenfrom May 15, 2024
Merged
Conversation
added 13 commits
May 11, 2024 17:34
1 task
Owner
lockshaw
approved these changes
May 15, 2024
Owner
lockshaw
left a comment
lockshaw
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @yingyee0111)
lockshaw
added a commit
that referenced
this pull request
Jun 3, 2024
* Add basic dtgen implementation * Add some basic e2e tests * Add rapidcheck support * Add fmt * Auto-run dtgen on build, test, and cmake * Update cpp snippets with new config module name * Change to actually correct module name * Add support for empty types * Add more helpful error message in load_spec * Blacklist build from format * Add better error message for spec parsing failure * Add format string specifier * Add enum support * Add missing __init__.py file * Add variant generation * Modify output filename * Fix modified filenames * Add out-of-date file detection * Add ability to remove outdated files * Add fmt feature for variants * Fix missing return in variant format_as * Add option to make constructors implicit * Try alternate visit implementation * Add additional fmt include to source code * Also add to struct rendering * Remove automatic utils/fmt.h inclusion * Add linting command * Add incremental generation * Add missing dependency * Add verbosity configuration * Fix bug in test suite * Fix build command in test project * Make verbosity level more clear * Fix incremental dtgen, simplify logging output * Implement rapidcheck for variant spec (#3) * adding rapidcheck for variant * fixing rapidcheck for variant * variant test --------- Co-authored-by: Rae Wong <raewong@sapling2.stanford.edu> * variant rapidcheck (#4) Co-authored-by: Rae Wong <raewong@sapling2.stanford.edu> * Fix falling back to curl to install clang-format (#5) --------- Co-authored-by: Colin Unger <lockshaw@lockshaw.net> Co-authored-by: Rae Wong <raewong@sapling2.stanford.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented rapidcheck arbitrary generation for variant.toml files.
Variant arbitrary generators implemented as
gen::oneOf(gen::cast<std::variant<Ts...>>(gen::arbitrary<Ts>())...);This change is