Skip to content

Remove the condition for scheduling the flush and call lambda. #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vilyapilya merged 2 commits into from
Jan 23, 2020
Merged

Remove the condition for scheduling the flush and call lambda. #22

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46717b4
fix the bug
lvilya Jan 22, 2020
28d743b
enclose into if else
lvilya Jan 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lib/logdna/client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def schedule_flush
sleep(@exception_flag ? @retry_timeout : @flush_interval)
flush if @flush_scheduled
}
thread = Thread.new { start_timer }
thread = Thread.new { start_timer.call }
thread.join
end

Expand All @@ -62,8 +62,11 @@ def write_to_buffer(msg, opts)
@flush_scheduled = true
@lock.unlock

flush if @flush_limit <= @buffer_byte_size
schedule_flush unless @flush_scheduled
if @flush_limit <= @buffer_byte_size
flush
else
schedule_flush
end
else
@side_message_lock.synchronize do
@side_messages.push(process_message(msg, opts))
Expand Down