Skip to content

Add Fee estimation for transfer, recovery and vault operations.#258

Merged
benoitdevos merged 3 commits intomainfrom
feature/estimate-transfer-fees
May 7, 2024
Merged

Add Fee estimation for transfer, recovery and vault operations.#258
benoitdevos merged 3 commits intomainfrom
feature/estimate-transfer-fees

Conversation

@benoitdevos
Copy link
Contributor

This PR mainly add fee estimations for transfer,recovery and vault operations.
Additionally, it generalizes usage of pattern:

interface OpParams {}

async operation(params: BlockchainSubmission<OpParams>) {}

async estimateFeesOperation(params: OpParams): Promise<FeesClass> {}

logion-network/logion-internal#1233

Copy link
Contributor

@gdethier gdethier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, nice refactoring!

@benoitdevos benoitdevos merged commit 6c35013 into main May 7, 2024
@benoitdevos benoitdevos deleted the feature/estimate-transfer-fees branch May 7, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants