Do not raise exception on flusher stop #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nnonexistent
changed the title
curusarn
requested changes
Dec 4, 2023
Contributor
curusarn
left a comment
curusarn
left a comment
There was a problem hiding this comment.
Thanks a lot for the PR! Sorry for the wait!
Left some minor comments. Otherwise looks good!
curusarn
approved these changes
Dec 4, 2023
curusarn
reviewed
Dec 4, 2023
curusarn
reviewed
Dec 4, 2023
curusarn
reviewed
Dec 4, 2023
curusarn
reviewed
Dec 4, 2023
Contributor
Author
|
@curusarn I see you've already edited code to your preferences - thanks! I, hopefully, fixed the skip condition for 3.7 python - pls run the workflow to verify it. If you need something else done in this PR, please let me know |
Contributor
|
Thanks! I ran the workflow, and it passed. Everything looks good. I will merge and release a version soon! |
Member
|
@Nnonexistent Thank you for the contribution, I just released it as v0.2.8 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18